Repository navigation
fix(security): align telemetry peers and runtime dependencies - #2398
Closed
dependabot[bot] wants to merge 11 commits into
Closed
dependabot[bot] wants to merge 11 commits into
dependabot[bot] wants to merge 11 commits into
Conversation
Bumps [@opentelemetry/instrumentation](https://github.com/open-telemetry/opentelemetry-js) from 0.222.0 to 0.223.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-js/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-js/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-js@experimental/v0.222.0...experimental/v0.223.0) --- updated-dependencies: - dependency-name: "@opentelemetry/instrumentation" dependency-version: 0.223.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
the
dependencies
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the
 |
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
Contributor
Dependency ReviewThe following issues were found:
OpenSSF ScorecardScorecard details
Scanned Files
|
groupthinking
requested changes
Oct 28, 2026
groupthinking
left a comment
groupthinking
left a comment
Owner
There was a problem hiding this comment.
Review at head fc000868: dependency-review fails because it detected incompatible licenses. This manifest-only telemetry update needs the flagged dependency/license resolved and the dependency check passing before approval.
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
groupthinking
previously approved these changes
Oct 28, 2026
groupthinking
left a comment
groupthinking
left a comment
Owner
There was a problem hiding this comment.
Code review at exact head 77a02794a392091d9a3f8a839123b6f51ad9e3fe: The old incompatible-license finding named numpy@2.5.4 in Python requirements files; none of those paths changes in this PR. The exact two-file diff updates only web @opentelemetry/instrumentation@0.223.0 and its synchronized Apache-2.0 npm lock entries. I verified a clean npm 10.8.0 install, package resolution, 1,520 passing web tests (28 skipped), lint, typecheck and build; current hosted code checks pass. This approval covers the scoped code/lock correction and the old out-of-scope numpy finding only. The shared dependency-review job still has a 3-base/1-head snapshot warning and no reliable complete evidence artifact, so its partial license result is not a complete verdict. Keep this PR open and unmerged until that check passes on the final head.
…ry/instrumentation-0.223.0
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
groupthinking
changed the title
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
groupthinking
changed the title
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
This was referenced Nov 2, 2026
Contributor
🔍 PR Validation |
groupthinking
changed the title
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
groupthinking
changed the title
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
groupthinking
approved these changes
Nov 10, 2026
groupthinking
left a comment
groupthinking
left a comment
Owner
There was a problem hiding this comment.
Reviewed exact head 108dc7f53b6a91308a3bf9c63493f92d74e9bae0 against 61522e9170a91bf8c8c6bf02f2e5dbdf2eb5bbd6. The incompatible-license finding and incomplete dependency-evidence blocker are resolved for this candidate. The scoped json-schema-typed9 override now reports BSD-3-Clause and passes strict SDK type/runtime regressions.
I inspected the complete eight-path diff and the merge of current main, preserving both current product changes and the tracing/security repairs. Clean installs, types, lint, 96 recorder tests, installed tracing compatibility tests and all 11 MCP security/runtime cases pass. Hosted validation passes 1,576 web cases (one existing skip), the 47-page application and Docker builds, 21 real Studio preflight checks, and 16 preview pipeline tests.
The current dependency review passed. I downloaded its artifact and independently verified the ZIP and raw-diff digests, exact base/head/run, successful outcome, and all 78 typed npm rows against the fresh live comparison. It contains zero vulnerability entries and no snapshot-warning or pagination header. No inline review threads remain. A repository-wide reconciliation report was cancelled because a newer report took its shared concurrency slot; that newer report completed successfully on PR #2399. This was not a source-test failure.
Approving these scoped source changes resolves my earlier requested changes. Remaining repository risks are explicit: full npm audit still reports 24 high/18 moderate findings (no new advisory IDs versus current main); the root Python scanner fell back to declared packages, leaving transitive coverage incomplete; preview tests may use cached packs. This review grants no audit exception, production-readiness claim, deployment or merge authorization. The PR remains open with auto-merge disabled.
Contributor
Author
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot
Bot
deleted the
dependabot/npm_and_yarn/apps/web/opentelemetry/instrumentation-0.223.0
branch
November 13, 2026 01:39
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed as superseded by #2399, which now carries the tested integration on main
512a2558f73d6281b6a880548bedf140b7e30292, head73ec0d4fe2d523e84f5d0212fba4522e768f06eb.Verified comparison of this head
108dc7f53b6a91308a3bf9c63493f92d74e9bae0with #2399's previous head13dc8cc31a00245f485378090ba7bca3fa2169feshows exactly one changed file: #2399 adds 23 lines of StackContextManager regression coverage. All source, dependency manifests/lock and configuration were otherwise identical. The source branch is preserved.The canonical repair's integrated tree passes 1,570 web tests (28 skipped), strict MCP types and 11 runtime/security cases, focused 24 compatibility/continuation tests, web types and lint. Fresh hosted CI/build/security acceptance remains pending; the local build exited 137. Closing this duplicate neither merges code nor waives any acceptance gate.
Historical description and its evidence, predating the integration:
The supported OpenTelemetry SDK 3 migration fixes instrumentation 0.300 loading API 1.9.1 without logging support and SDK 2.x packages rejecting the application's API 1.10. Root/web core and web resources use 3.0.0; maintained sdk-trace 3.0 replaces sdk-trace-base alongside API 1.10 and instrumentation/exporter 0.300, following the maintainer migration guide.
The existing Vite repair remains: root Vite 8.3.0→8.3.5, Rolldown 1.2.7→1.2.16, Oxc types 0.148→0.156 and 15 matching bindings. Its runtime-optional scope through @sentry/cloudflare is retained.
The runtime security repair updates @hono/node-server 2.0.12→2.1.5, hono 4.13.7→4.13.14, fast-uri 3.1.7→3.1.9 and ip-address 10.7.2→10.7.4 within their consumer ranges. Those four lock records and correct runtime-optional scope remain preserved. The eight vulnerable-behavior regressions fail on integrity-verified old tarballs and pass on the fixed graph; positive real MCP initialize/list-tools/tool-call and AJV local-reference tests also pass.
The repository license check flagged transitive json-schema-typed 8.0.2 as BSD-2-Clause AND JSON. This PR uses the publisher's 9.0.0 BSD-3-Clause release through an override scoped to @modelcontextprotocol/sdk. The SDK still declares ^8.0.2, so this intentionally crosses its dependency range. Both CommonJS and ESM strict TypeScript probes accept the supported nested/object schemas and reject boolean root schemas. Version 9 also rejects malformed numeric type keywords that 8 accepted. Actual SDK/AJV validation and local MCP initialize/list-tools/tool-call tests pass. No license allowlist or exception changes.
Root MCP dependency regressions now live in tests/security, outside production web compilation. The required test-frontend CI job runs npm run test:mcp-security: a strict TypeScript check followed by all 11 runtime/security cases. This repairs the Docker workspace-only install failure caused by placing root dependency tests under apps/web. All assertions remain intact; only the location and repository-relative dependency lookup change. The app TypeScript configuration, Dockerfile and dependency graph are unchanged by this build repair.
Current source:
108dc7f53b6a91308a3bf9c63493f92d74e9bae0against integrated main61522e9170a91bf8c8c6bf02f2e5dbdf2eb5bbd6. The history-preserving merge resolves root/web manifest and lockfile conflicts by retaining independent changes from both sides. Current main's Next 16.4.5 and newer provider packages remain. The final PR changes eight paths: root/web manifests, root lockfile, the installed OTel compatibility test, root MCP security test and its two configs, and CI. No application runtime source is changed relative to current main.Validation on this exact head, refreshed November 10, 2026:
npm ci --ignore-scripts --legacy-peer-deps --no-audit --no-fund, inspected web postinstall patcher,npm --workspace=apps/web run type-check,npm --workspace=apps/web run lint,npm --workspace=apps/web test,npm run test:mcp-security, andnpm run build:webpassed. Web result: 1,549 passed / 28 skipped; strict MCP types and 11/11 security cases passed; build generated 47/47 static pages. The 96 focused dependency workflow/pagination/unchanged-requirements tests also passed. Both manifests and the lockfile stayed unchanged during the frozen install and validation.The shared recorder blocker is resolved on this head. PR #2553 was merged separately on November 5. Its recorder now runs here through the current-main integration. The current dependency review passes both policy and evidence recording and uploads artifact
13757233725. The ZIP digest, internal raw-diff digest, exact base/head/run identity, all 78 typed npm rows, and successful review outcome were independently checked. Every row matches a fresh live GitHub comparison, with zero vulnerability entries, no pagination link, and an empty snapshot-warning header. json-schema-typed 9.0.0 is reported as BSD-3-Clause. This current comparison has no unchanged-Python-resolution rows; the earlier 86-row replay separately proved the recorder preserves resolution drift and both success/failure outcomes.All 28 current-head checks finished: 25 passed and 3 skipped; no open inline review threads at verification. The PR remains open with auto-merge disabled. Earlier hosted results on November 3 are historical and are superseded by the current-head evidence above.
Limits: the complete local npm audit still exits 1, with 24 high and 18 moderate findings, versus 25 high and 22 moderate on current main's lockfile; it introduces no new advisory IDs in that comparison. These remaining findings are not waived. The current hosted scanner failed to resolve root
requirements.txtafter four minutes (exit 137) and fell back to declared packages, so Python transitive coverage remains incomplete despite the empty snapshot-warning header. Existing Workflow Nest/SWC missing-peer, optional Sharp and root picomatch/PostCSS override warnings are not waived. fast-uri 3.1.9 normalizes invalid suffix input unchanged while parse reports an error; the tested protection is suffix serializer escaping, not general URL sanitization. Actual tracked AJV/MCP consumers use default resolver options.Security dependency evidence